Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings7 #833

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Warnings7 #833

merged 4 commits into from
Aug 10, 2023

Conversation

martijn00
Copy link
Contributor

@ebozduman
Copy link
Collaborator

PR #832 might help here.
Let's rebase when PR #832 is merged.

ebozduman
ebozduman approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman
Copy link
Collaborator

@martijn00

If you can rebase, I think the functional tests will pass.

@martijn00
Copy link
Contributor Author

@ebozduman done the rebase

@ebozduman ebozduman merged commit e3fc073 into minio:master Aug 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martijn00 @ebozduman