Fixes adding additional QueryParameters to http request #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
approved these changes
Aug 13, 2023
|
hey @martijn00 , I've written an additional test making clear the expected behavior. |
martijn00
approved these changes
Aug 19, 2023
|
@ebozduman can you run this and review? |
|
@tvdias can you run format on this branch? |
I run the tool to format both files and updated the PR, but it didn't run the pipeline again, so I can't confirm this is now as expected. |
tvdias
force-pushed
the
FixHttpRequestMessageBuilder
branch
from
352f278
to
45c36f2
Compare
|
It looks like functional tests have failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there's an issue on HttpRequestMessageBuilder.Request getter. I've written a test and could check it doesn't do what I expected it to do.
I've changed it to get Uri's query parameters and always append
QueryParameters.