Fix inheritance and add servicecollection #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
force-pushed
the
servicecollection
branch
from
0e9ce39
to
11ed7f3
Compare
|
Will do the review in during CA work hours... |
ebozduman
reviewed
Aug 28, 2023
|
The IMinioClient interface didn't inherit the 2 other interfaces, but the implementation did implement them. For that reason the methods in the interface were also duplicated. I've removed that. I'm now working towards a more interface based implementation of minio so that it the standard DI container of .net can use it. This is a first step towards an easier way to implement Minio. You can call AddMinio in your normal api build and resolve IMinioClient or IMinioClientFactory through DI or the service locator after that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ebozduman