Fixes the Minio5.0 nuget cancellationToken issue #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
approved these changes
Sep 20, 2023
martijn00
approved these changes
Sep 21, 2023
|
@ebozduman can you merge and make the release? |
|
ping @balamurugana, @krisis |
|
@ebozduman can you please add verification steps as well? |
shtripat
approved these changes
Sep 28, 2023
|
@ebozduman since this change switches the token that comes from the CancellationTokenSource for the one passed into the callback, are lines 91-94 still required? I was looking at this code to try and see if there was some sort of default timeout configured for these requests and found it confusing that we create this CancellationTokenSource and then do nothing with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #864