Adds support for newly bumped up Meziantou.Analyzer #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsvmx
approved these changes
Jan 17, 2024
martijn00
reviewed
Feb 7, 2024
| @@ -54,7 +53,7 @@ public ReplicationConfiguration(string role, Collection<ReplicationRule> rules) | |||
|
|
|||
| [XmlElement("Role")] public string Role { get; set; } | |||
|
|
|||
| [XmlElement("Rule")] public Collection<ReplicationRule> Rules { get; set; } | |||
| [XmlElement("Rule")] public ICollection<ReplicationRule> Rules { get; set; } | |||
There was a problem hiding this comment.
@ebozduman XML needs a concrete type. Setting this to an interface might break things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping Meziantou.Analyzer from 2.0.127 to 2.0.136 PR #983 caused dotnet build to fail due to some code Analyzer complained about.
This PR is for these changes.