allow disabling sha256 completely for PUT requests #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested review from
klauspost,
kannappanr,
poornas and
krisis
and removed request for
klauspost and
kannappanr
harshavardhana
force-pushed
the
allow-sha256
branch
from
28cbfd5
to
ba79d57
Compare
poornas
approved these changes
Jun 23, 2022
agnivade
added a commit
to mattermost/mattermost
that referenced
this pull request
Aug 19, 2022
PR minio/minio-go#1668 introduced an option to disable sha256, which by default was disabled. This meant all content was always hashed and this broke in bifrost because the key signing fails in streaming mode. So for cloud installations, we disable sha256. https://mattermost.atlassian.net/browse/MM-46475 ```release-note NONE ```
agnivade
added a commit
to mattermost/mattermost
that referenced
this pull request
Aug 20, 2022
PR minio/minio-go#1668 introduced an option to disable sha256, which by default was disabled. This meant all content was always hashed and this broke in bifrost because the key signing fails in streaming mode. So for cloud installations, we disable sha256. https://mattermost.atlassian.net/browse/MM-46475 ```release-note NONE ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.