Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lifecycle: Incl. empty Prefix when all else empty #1907

Merged
merged 1 commit into from
Nov 30, 2023
Merged

lifecycle: Incl. empty Prefix when all else empty #1907

merged 1 commit into from
Nov 30, 2023

Conversation

krisis
Copy link
Member

@krisis krisis commented Nov 29, 2023

Steps to reproduce

  • mc ilm rule add --expire-days 1 --size-gt 512KiB --debug myminio/bucket
  • This fails even when tested on AWS S3.

The bug here is that Filter's MarshalXML method includes an empty Prefix tag when we have a non-empty size based predicate present.

vadmeste
vadmeste approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vadmeste
vadmeste requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disapprove for a moment

@krisis krisis force-pushed the ilm-sz-fix branch 2 times, most recently from f37aaff to 9807672 Compare November 29, 2023 23:58
vadmeste
vadmeste approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 54e115c into minio:master Nov 30, 2023
7 checks passed
@krisis krisis mentioned this pull request Nov 30, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@vadmeste vadmeste vadmeste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krisis @vadmeste @harshavardhana