Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip bucket/region/object name validation as special usecase #1576

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

rudgal
Copy link
Contributor

@rudgal rudgal commented Aug 5, 2024

Hello,

the minio-java client is my preferred way to access S3 buckets within java projects.

Unfortunately in my current project I need to access an on-premises S3 bucket.
For some historic reasons the bucketname contains underscores and as such does not adhere to the official naming rules.
Sadly I have no means to correct this bucketname easily without causing severe efforts throughout the organization.

For this reason I would appreciate to have a possibility to disable the validation in such cases.
With this PR I'd like to propose a feasible solution.

I researched passt issues/change-requests, this might also be related to #1564 .

api/src/main/java/io/minio/BucketArgs.java Outdated Show resolved Hide resolved
api/src/test/java/io/minio/MakeBucketArgsTest.java Outdated Show resolved Hide resolved
@rudgal
Copy link
Contributor Author

rudgal commented Aug 5, 2024

Thanks for your feedback, adapted it accordingly.

@balamurugana balamurugana changed the title Allow to ignore bucketName validation in BucketArgs.Builder Add skip bucket/region/object name validation as special usecase Aug 5, 2024
@harshavardhana harshavardhana merged commit e85d171 into minio:master Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants