common-java:DuplicatedBlocks - Source files should not have any duplicated blocks #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two trivial issues need to be fixed to pass travis. error description is at http://pmd.sourceforge.net/pmd-5.2.3/pmd-java/rules/java/empty.html#EmptyStatementNotInLoop |
|
|
||
|
|
||
| private static long readBytes(int len, |
There was a problem hiding this comment.
Please add a comment about this function.
…cated blocks squid:MethodCyclomaticComplexity - Methods should not be too complex
|
@balamurugana Updated |
|
👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule
common-java:DuplicatedBlocks - Source files should not have any duplicated blocks.
squid:MethodCyclomaticComplexity - Methods should not be too complex.
This pull request removes 54 minutes of technical debt.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/common-java:DuplicatedBlocks
https://dev.eclipse.org/sonar/rules/show/squid:MethodCyclomaticComplexity
Please let me know if you have any questions.
George Kankava