Merge pull request #361 from harshavardhana/periods

helpers: bucket name now validates for double periods.
minio · Jan 21, 2016 · f9b54dd · f9b54dd
2 parents 0001126 + 7b77808
commit f9b54dd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/minio/helpers.py b/minio/helpers.py
@@ -349,6 +349,9 @@ def is_valid_bucket_name(bucket_name):
     if len(bucket_name) > 63:
         raise InvalidBucketError('Bucket name cannot be more than'
                                  ' 63 characters.')
+    if '..' in bucket_name:
+        raise InvalidBucketError('Bucket name cannot have successive'
+                                 ' periods.')
 
     match = _VALID_BUCKETNAME_REGEX.match(bucket_name)
     if match is None or match.end() != len(bucket_name):

diff --git a/tests/unit/minio_test.py b/tests/unit/minio_test.py
@@ -35,6 +35,14 @@ def test_bucket_name_invalid_characters(self):
     def test_bucket_name_length(self):
         is_valid_bucket_name('dd')
 
+    @raises(InvalidBucketError)
+    def test_bucket_name_periods(self):
+        is_valid_bucket_name('dd..mybucket')
+
+    @raises(InvalidBucketError)
+    def test_bucket_name_begins_period(self):
+        is_valid_bucket_name('.ddmybucket')
+
 class GetURLTests(TestCase):
     def test_get_target_url_works(self):
         url = 'http://localhost:9000'