Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle response xml inside s3 error class #1015

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Handle response xml inside s3 error class #1015

merged 1 commit into from
Nov 11, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Nov 9, 2020 •
edited
Loading

No description provided.

@balamurugana balamurugana marked this pull request as draft November 9, 2020 19:25
@balamurugana balamurugana force-pushed the Handle-response-XML-inside-S3Error-class branch from 9e8de28 to 0604ed2 Compare November 10, 2020 05:11
@balamurugana balamurugana marked this pull request as ready for review November 10, 2020 05:14
kannappanr
kannappanr approved these changes Nov 10, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr requested a review from ebozduman November 10, 2020 21:34
ebozduman
ebozduman approved these changes Nov 11, 2020
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 71b2280 into minio:master Nov 11, 2020
@balamurugana balamurugana deleted the Handle-response-XML-inside-S3Error-class branch November 11, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannappanr kannappanr kannappanr approved these changes

@ebozduman ebozduman ebozduman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @ebozduman @kannappanr