Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge definitions.py into helpers.py #1017

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Merge definitions.py into helpers.py #1017

merged 1 commit into from
Nov 11, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana force-pushed the Merge-definitions-py-into-helpers-py branch from d10ebcd to 691accf Compare November 10, 2020 16:11
kannappanr
kannappanr previously approved these changes Nov 10, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr requested a review from poornas November 10, 2020 21:28
@balamurugana balamurugana force-pushed the Merge-definitions-py-into-helpers-py branch from 691accf to 4690cbd Compare November 11, 2020 14:45
kannappanr
kannappanr approved these changes Nov 11, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

poornas
poornas approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 6fa1fa5 into minio:master Nov 11, 2020
@balamurugana balamurugana deleted the Merge-definitions-py-into-helpers-py branch November 12, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannappanr kannappanr kannappanr approved these changes

@poornas poornas poornas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @poornas @kannappanr