-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples and documentations #1038
Fix examples and documentations #1038
Conversation
86e5217
to
9163164
Compare
9163164
to
41eda21
Compare
f1411e1
to
53a2a87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
86e9094
to
a4c2dbd
Compare
a4c2dbd
to
3137e36
Compare
3137e36
to
ea3578d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, most of my feedback are nits and are closer to being "polish" than something that is absolutely necessary. If the priority is to get this out, I don't think anything here would be a hard block to user success.
README.md
Outdated
This example program connects to a MinIO object storage server, makes a bucket on the server and then uploads a file to the bucket. | ||
This example program connects to an object storage server, makes a bucket on the server and then uploads a file to the bucket. | ||
|
||
You need three items in order to connect to an object storage server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need three items in order to connect to an object storage server. | |
You need the following items to connect to an S3-compatible object storage server: |
ea3578d
to
1e2e531
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.