make_bucket: use region passed via constructor #1103
Conversation
| @@ -619,7 +619,7 @@ def make_bucket(self, bucket_name, location=None, object_lock=False): | |||
| self._base_url.region, location, | |||
| ), | |||
| ) | |||
| location = location or "us-east-1" | |||
| location = self._base_url.region or location or "us-east-1" | |||
There was a problem hiding this comment.
| location = self._base_url.region or location or "us-east-1" | |
| location = location or self._base_url.region or "us-east-1" |
There was a problem hiding this comment.
Should it be this, as the user is explicitly specifying the location they want to use, even if the region is set in the constructor?
There was a problem hiding this comment.
No. It is not allowed. It will make confusion in other APIs.
There was a problem hiding this comment.
This is a general comment.
Wouldn't it be better to define a constant for the default region instead of hard coding it in several different places (5) in the code?
_DEFAULT_REGION = "us-east-1"
There was a problem hiding this comment.
I think this is out of scope of this PR.
There was a problem hiding this comment.
so, if region is specified in the constructor, and also specified in the make_bucket call and they are different, do we reject it?
| @@ -619,7 +619,7 @@ def make_bucket(self, bucket_name, location=None, object_lock=False): | |||
| self._base_url.region, location, | |||
| ), | |||
| ) | |||
| location = location or "us-east-1" | |||
| location = self._base_url.region or location or "us-east-1" | |||
There was a problem hiding this comment.
This is a general comment.
Wouldn't it be better to define a constant for the default region instead of hard coding it in several different places (5) in the code?
_DEFAULT_REGION = "us-east-1"
Fixes #1102