fix: pylint build issues in minio-py #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-keys
branch
4 times, most recently
from
abfd57e to
e1d5549
Compare
balamurugana
previously requested changes
May 25, 2021
harshavardhana
force-pushed
the
fix-keys
branch
2 times, most recently
from
1826c48 to
dd54f21
Compare
harshavardhana
force-pushed
the
fix-keys
branch
2 times, most recently
from
fe33fb7 to
ba9bbab
Compare
Bonus: also stringify the `key` for additional metadata, otherwise key's with numeric names might fail with key ValueError.
balamurugana
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: also stringify the
keyforadditional metadata, otherwise key's with
numeric names might fail with key ValueError.