Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transition xml name in lifecycleconfig #1142

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Aug 11, 2021

Fixes #1141

Signed-off-by: Bala.FA bala@minio.io

harshavardhana
harshavardhana previously approved these changes Aug 11, 2021
@harshavardhana
Copy link
Member

@balamurugana can we add a test for this?

@balamurugana
Copy link
Member Author

@balamurugana can we add a test for this?

Unit tests are already there for XML marshal/unmarshal. For this specific case, it is required to have functional tests where minio-py is lagging.

@indianwhocodes
Copy link

Will this be part of the next release ?

harshavardhana
harshavardhana previously approved these changes Sep 30, 2021
Fixes minio#1141

Signed-off-by: Bala.FA <bala@minio.io>
@harshavardhana harshavardhana merged commit 28b67c4 into minio:master Oct 8, 2021
@balamurugana balamurugana deleted the fix-issue-1141 branch October 9, 2021 02:28
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Sorry for the belated review. I forgot to hit the button when I was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Malformed XML error" when using set_bucket_lifecycle
4 participants