Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and add codespell GitHub Action #1251

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Dec 3, 2022

Found via codespell -S .mypy_cache

Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add codespell into github workflow as well?

@kianmeng
Copy link
Contributor Author

kianmeng commented Dec 4, 2022

@balamurugana As a separate individual workflow or append into existing one in https://github.com/minio/minio-py/tree/master/.github/workflows?

@balamurugana
Copy link
Member

@balamurugana As a separate individual workflow or append into existing one in https://github.com/minio/minio-py/tree/master/.github/workflows?

Just add it to https://github.com/minio/minio-py/blob/master/.github/workflows/pythonpackage-linux.yml

@kianmeng kianmeng changed the title Fix typos Fix typos and add codespell GitHub Action Dec 4, 2022
@kianmeng kianmeng requested a review from balamurugana December 4, 2022 07:19
@@ -19,6 +19,7 @@ jobs:
os: [ubuntu-latest]

steps:
- uses: codespell-project/actions-codespell@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not working

Found via `codespell -S .mypy_cache`
@harshavardhana harshavardhana merged commit b798dc9 into minio:master Dec 4, 2022
@kianmeng
Copy link
Contributor Author

kianmeng commented Dec 5, 2022

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants