api: Fix python3 compatibility issue by using compat values. #400
Conversation
|
ping @balamurugana |
| @@ -336,7 +336,8 @@ def get_bucket_policy(self, bucket_name, prefix=""): | |||
|
|
|||
| return policy.get_policy(statements, bucket_name, prefix) | |||
|
|
|||
| def set_bucket_policy(self, policy_access, bucket_name, prefix=""): | |||
| def set_bucket_policy(self, bucket_name, prefix="", | |||
| policy_access=policy.Policy.NONE): | |||
There was a problem hiding this comment.
Its good to not to have policy_access is an optional argument.
There was a problem hiding this comment.
Optional is because its a default case is remove bucket policy.
There was a problem hiding this comment.
Why do we need remove as default? In most of the cases a valid bucket policy is set. Having Policy.NONE as default would lead to loosing the policy when the API is called with wrong code. I feel making policy_access mandate to avoid such errors.
There was a problem hiding this comment.
Why do we need remove as default? In most of the cases a valid bucket policy is set. Having Policy.NONE as default would lead to loosing the policy when the API is called with wrong code. I feel making policy_access mandate to avoid such errors.
That we can do and not have any optional params for this API.
harshavardhana
force-pushed
the
fix-python-3
branch
from
f4b1202 to
e601022
Compare
Also fix the API set_bucket_policy() should take input policy as the last option and API should be consistent with other languages. This patch also adds a functional test case. Fixes minio#399
harshavardhana
force-pushed
the
fix-python-3
branch
from
e601022 to
a0e8e95
Compare
|
LGTM 👍 |
Also fix the API set_bucket_policy() should take input
policy as the last option and API should be consistent
with other languages.
This patch also adds a functional test case.
Fixes #399