signV4: Fix signature issue while doing multipart upload. #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
uploads-sign
branch
2 times, most recently
from
d7c6db4 to
0e38b3f
Compare
Setting query params in the following manner fails to
generate the proper query params used for validating
signature.
```
query = {'test': None}
```
Generates a url of form `/?test` doesn't work.
```
query = {'test': ''}
```
Generates a url of form `/?test=` works.
harshavardhana
force-pushed
the
uploads-sign
branch
from
0e38b3f to
1f73c31
Compare
krisis
approved these changes
Apr 17, 2017
harshavardhana
requested review from
krisis and
vadmeste
and removed request for
donatello and
balamurugana
vadmeste
approved these changes
Apr 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting query params in the following manner fails to
generate the proper query params used for validating
signature.
Generates a url of form
/?testdoesn't work.Generates a url of form
/?test=works.