fix: Use urllib.quote() instead of pathname2url() #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listening to bucket events is not working properly for Windows since pathname2url was trying to encode s3:ObjectCreated:* which is not a valid path under Windows. Correct the behavior by using urllib.quote() and unquote() instead.
harshavardhana
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listening to bucket events is not working properly for Windows
since pathname2url was trying to encode s3:ObjectCreated:* which
is not a valid path under Windows. Correct the behavior by using
urllib.quote() and unquote() instead.
Fix #523
Function and unit tests are passing.