signv4: Strip port 80 & 443 from url #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curl & browsers strip port 80 and 443 from host header when a user tries to open a presigned urls, the thing that leads to a signature mismatch error. This PR strips port 80/443 by default.
harshavardhana
approved these changes
May 29, 2017
|
We need to also check this across all libraries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl & browsers strip port 80 and 443 from host header when a user tries
to open a presigned urls, the thing that leads to a signature mismatch error.
This PR strips port 80/443 by default.
Fixes #527