fget_object: Delete existing file in destination path before copying #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit title should indicate what this PR does |
kannappanr
reviewed
Jun 20, 2018
minio/api.py
Outdated
| @@ -599,7 +599,12 @@ def fget_object(self, bucket_name, object_name, file_path, request_headers=None) | |||
| raise InvalidSizeError(msg) | |||
|
|
|||
| # Rename with destination file. | |||
| os.rename(file_part_path, file_path) | |||
| if not(os.path.exists(file_path)): | |||
There was a problem hiding this comment.
This can be changed to
if os.path.exists(file_path):
os.remove(file_path)
os.rename(file_part_path, file_path)
Colhodm
changed the title
Colhodm
force-pushed
the
windows-fgetobject-fix
branch
from
29457f3 to
01f64f4
Compare
Colhodm
changed the title
Colhodm
force-pushed
the
windows-fgetobject-fix
branch
from
01f64f4 to
277cb8b
Compare
Colhodm
changed the title
kannappanr
changed the title
ebozduman
requested changes
Jun 20, 2018
minio/api.py
Outdated
| os.rename(file_part_path, file_path) | ||
|
|
||
| # Return the stat | ||
|
|
There was a problem hiding this comment.
Clean up unnecessary spaces and fix the indentation of the comment.
# Return the stat
277cb8b to
59fd06a
Compare
Colhodm
force-pushed
the
windows-fgetobject-fix
branch
from
59fd06a to
58e8a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Windows OS, if the file that fget_object refers to already exists.
Fixes #665