Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar #723

Merged
merged 21 commits into from
Jan 29, 2019
Merged

Add progress bar #723

merged 21 commits into from
Jan 29, 2019

Conversation

rkdls
Copy link
Contributor

@rkdls rkdls commented Dec 8, 2018

Changed the put, fput function to display the progress every 5MB.

Users can pass a custom function as an argument to 'progress' and display it on the screen.

minio/api.py Show resolved Hide resolved
minio/api.py Show resolved Hide resolved
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two comments rest of the things look good

minio/api.py Show resolved Hide resolved
minio/api.py Show resolved Hide resolved
@harshavardhana
Copy link
Member

PTAL @vadmeste

harshavardhana
harshavardhana previously approved these changes Jan 14, 2019
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the nice change @rkdls

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

@kannappanr kannappanr merged commit ce9a918 into minio:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants