-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: More fixes for better support of Github CI #812
Conversation
Looks like functional tests hang and GitHub cancels the CI
|
It looks like Github cancels when there is one failed job, that's why it has two netural checks |
jobs.<job_id>.strategy.fail-fast |
e4f68b2
to
7e3494e
Compare
I made some changes and some advancements in Github CI but still struggling with connection reset error.. |
48f6330
to
7e7f860
Compare
I think you should download MinIO locally and run it like minio-go https://github.com/minio/minio-go/blob/master/.travis.yml#L19 |
yes, good idea |
602babd
to
c7fb794
Compare
1376177
to
00e7735
Compare
This is finally ready to review & merge. |
why generate @vadmeste commit to the minio-py since we have to use a static 127.0.0.1 IP anyways |
NOTE: on windows you need it to be 127.0.0.1 not localhost @vadmeste so cert should be IP SANs |
85cb81c
to
da87b74
Compare
1. Explicity create and pass temporary directories in tests 2. Download Minio binary for both Linux & Windows and avoid testing directly against Play server
It looks like it works fine with localhost |
Explicity create and pass temporary directories in tests
Download Minio binary for both Linux & Windows and avoid
testing directly against Play server