Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not need to set max-keys, max-uploads and max-parts #819

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

harshavardhana
Copy link
Member

MinIO server supports now 10k elements in the list output,
there is no reason for client to limit itself let the
default set of keys be returned and limited by server
implementation

MinIO server supports now 10k elements in the list output,
there is no reason for client to limit itself let the
default set of keys be returned and limited by server
implementation
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr requested a review from krisis October 31, 2019 20:53
@kannappanr
Copy link
Collaborator

$ mc admin trace myminio
^[[A12:23:32.990 [200 OK] s3.GetBucketLocation localhost:9000/test?location=  127.0.0.1         526µs       ↑ 82 B ↓ 382 B
12:23:32.995 [200 OK] s3.ListObjectsV1 localhost:9000/test/?max-keys=1000&prefix=  127.0.0.1         511µs       ↑ 93 B ↓ 507 B
12:23:32.998 [200 OK] s3.ListObjectsV2 localhost:9000/test/?list-type=2&prefix=&start-after=  127.0.0.1         409µs       ↑ 93 B ↓ 513 B

Listing in listobjectsV1 on the client side is still listing only 1000 objects at a time?

@harshavardhana
Copy link
Member Author

@kannappanr that's not possible unless you are using an old version.

@kannappanr kannappanr merged commit d5cd5da into minio:master Nov 1, 2019
@harshavardhana harshavardhana deleted the fix-list branch November 1, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants