Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pylint errors in compat.py #906

Merged
merged 1 commit into from
May 10, 2020
Merged

fix pylint errors in compat.py #906

merged 1 commit into from
May 10, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana force-pushed the fix-pylint-errors-in-compat-py branch from 5b10199 to 73e093d Compare May 4, 2020 16:31
@kannappanr kannappanr requested review from vadmeste and BigUstad May 5, 2020 10:59
@balamurugana balamurugana force-pushed the fix-pylint-errors-in-compat-py branch from 73e093d to 4e7e97f Compare May 6, 2020 08:15
BigUstad
BigUstad previously approved these changes May 7, 2020
View reviewed changes
Copy link

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the fix-pylint-errors-in-compat-py branch from 4e7e97f to ede69cf Compare May 7, 2020 06:38
vadmeste
vadmeste previously approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the fix-pylint-errors-in-compat-py branch 5 times, most recently from f6beb74 to 9c9ccd0 Compare May 8, 2020 06:17
@balamurugana balamurugana force-pushed the fix-pylint-errors-in-compat-py branch from 9c9ccd0 to 03947d6 Compare May 10, 2020 05:45
kannappanr
kannappanr approved these changes May 10, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit bc503e8 into minio:master May 10, 2020
@balamurugana balamurugana deleted the fix-pylint-errors-in-compat-py branch May 10, 2020 16:18
@johnnyvf24
Copy link
Contributor

johnnyvf24 commented Oct 19, 2020 •
edited
Loading

Hey! you guys broke my changes for #912 !? Without that single line change the minio client is incompatible with netapp storage grid. Can you please re-add something equivalent to

headers['X-Amz-Copy-Source'] = queryencode(
            object_source).replace('%2F', '/')

?

I've been waiting forever for PyPi to have a release that works with netapp.

@balamurugana
Copy link
Member Author

@johnnyvf24 We have removed python 2 compatibility and master handles the case as per python 3. Please check https://github.com/minio/minio-py/blob/master/minio/helpers.py#L82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannappanr kannappanr kannappanr approved these changes

@BigUstad BigUstad BigUstad left review comments

@vadmeste vadmeste vadmeste left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@balamurugana @johnnyvf24 @vadmeste @BigUstad @kannappanr