Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify non-empty string check #951

Merged
merged 1 commit into from
Aug 6, 2020
Merged

simplify non-empty string check #951

merged 1 commit into from
Aug 6, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

harshavardhana
harshavardhana previously approved these changes Aug 5, 2020
View reviewed changes
@balamurugana balamurugana force-pushed the simplify-non-empty-string-check branch from 172cf66 to 42a90d6 Compare August 6, 2020 04:35
@harshavardhana harshavardhana requested a review from vadmeste August 6, 2020 04:54
vadmeste
vadmeste approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit a7d7382 into minio:master Aug 6, 2020
@balamurugana balamurugana deleted the simplify-non-empty-string-check branch August 6, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@vadmeste vadmeste vadmeste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balamurugana @vadmeste @harshavardhana @kannappanr