merge list_objects_v2() into list_objects() method #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
merge-list_objects_v2-into-list_objects-method
branch
3 times, most recently
from
6afee6c to
a955a53
Compare
vadmeste
previously approved these changes
Aug 10, 2020
Yes, unfortunately, we will have to do that @vadmeste |
kannappanr
reviewed
Aug 12, 2020
tests/unit/list_objects_test.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # MinIO Python Library for Amazon S3 Compatible Cloud Storage, | |||
| # (C) 2015, 2016 MinIO, Inc. | |||
| # (C) 2015 MinIO, Inc. | |||
There was a problem hiding this comment.
Suggested change
| # (C) 2015 MinIO, Inc. | |
| # (C) 2015-2020 MinIO, Inc. |
balamurugana
force-pushed
the
merge-list_objects_v2-into-list_objects-method
branch
2 times, most recently
from
5be8a19 to
c7e4734
Compare
balamurugana
force-pushed
the
merge-list_objects_v2-into-list_objects-method
branch
from
c7e4734 to
c43362b
Compare
|
Depends on #966 |
balamurugana
force-pushed
the
merge-list_objects_v2-into-list_objects-method
branch
from
c43362b to
3a9b22d
Compare
vadmeste
reviewed
Aug 31, 2020
| @@ -32,8 +32,8 @@ | |||
|
|
|||
| # List all object paths in bucket that begin with my-prefixname using | |||
| # V2 listing API. | |||
| objects = client.list_objects_v2('my-bucketname', prefix='my-prefixname', | |||
| recursive=True) | |||
| objects = client.list_objects('my-bucketname', prefix='my-prefixname', | |||
There was a problem hiding this comment.
This example has duplicated code after your change, I guess you need to use api v1 in the first line and update some wording
harshavardhana
approved these changes
Aug 31, 2020
balamurugana
deleted the
merge-list_objects_v2-into-list_objects-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.