-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace {list,remove}_incomplete_uploads with private methods. #967
replace {list,remove}_incomplete_uploads with private methods. #967
Conversation
Depends on #966 |
da0fadc
to
4b28017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more references to list_incomplete_uploads
and remove_incomplete_upload
methods in the following files:
- api.py (4 places)
- docs/zh_CN/API.md (10 places)
- README_zh_CN.md (8 places)
The following 2 examples also need to be removed:
- examples/list_incomplete_uploads.py
- examples/remove_incomplete_upload.py
4b28017
to
5200171
Compare
I am not updating these files as they are quite out of sync with
Removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balamurugana I am still thinking that we should perhaps keep this for minio-py users with AWS S3, I know that we abort the uploads upon any error, but it is possible that some stale information is leftover and there is no way to clean them up.
Also keeping this API just allows for testing some API functionality through minio-py for MinIO so we might as well leave it as is and its not much of trouble to carry this code around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if we decide to remove them.
4ae2797
4ae2797
to
4725efc
Compare
51de548
to
89e4762
Compare
As `minio-py` does not leave stale multipart uploads, `list_incomplete_uploads()` and `remove_incomplete_uploads()` methods are removed, but introduced new private methods `_list_mulitpart_uploads()` and `_list_parts()` for low level usage.
89e4762
to
36f9dd4
Compare
As
minio-py
does not leave stale multipart uploads,list_incomplete_uploads()
andremove_incomplete_uploads()
methods areremoved, but introduced new private methods
_list_mulitpart_uploads()
and_list_parts()
for low level usage.