Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace {list,remove}_incomplete_uploads with private methods. #967

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Aug 24, 2020

As minio-py does not leave stale multipart uploads,
list_incomplete_uploads() and remove_incomplete_uploads() methods are
removed, but introduced new private methods _list_mulitpart_uploads() and
_list_parts() for low level usage.

@balamurugana
Copy link
Member Author

Depends on #966

@balamurugana balamurugana force-pushed the remove-methods-list-remove-incomplete-uploads branch 3 times, most recently from da0fadc to 4b28017 Compare August 26, 2020 20:31
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balamurugana,

There are more references to list_incomplete_uploads and remove_incomplete_upload methods in the following files:

  • api.py (4 places)
  • docs/zh_CN/API.md (10 places)
  • README_zh_CN.md (8 places)

The following 2 examples also need to be removed:

  • examples/list_incomplete_uploads.py
  • examples/remove_incomplete_upload.py

@balamurugana balamurugana force-pushed the remove-methods-list-remove-incomplete-uploads branch from 4b28017 to 5200171 Compare August 30, 2020 05:14
@balamurugana
Copy link
Member Author

balamurugana commented Aug 30, 2020

@ebozduman

There are more references to list_incomplete_uploads and remove_incomplete_upload methods in the following files:

* api.py (4 places)

remove_incomplete_upload() is needed internally. However PR #968 removes completely.

* docs/zh_CN/API.md (10 places)
* README_zh_CN.md (8 places)

I am not updating these files as they are quite out of sync with README.md and docs/API.md.

The following 2 examples also need to be removed:

* examples/list_incomplete_uploads.py
* examples/remove_incomplete_upload.py

Removed.

Praveenrajmani
Praveenrajmani previously approved these changes Aug 31, 2020
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balamurugana I am still thinking that we should perhaps keep this for minio-py users with AWS S3, I know that we abort the uploads upon any error, but it is possible that some stale information is leftover and there is no way to clean them up.

Also keeping this API just allows for testing some API functionality through minio-py for MinIO so we might as well leave it as is and its not much of trouble to carry this code around.

ebozduman
ebozduman previously approved these changes Sep 1, 2020
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we decide to remove them.

@balamurugana balamurugana force-pushed the remove-methods-list-remove-incomplete-uploads branch from 4ae2797 to 4725efc Compare September 1, 2020 17:13
harshavardhana
harshavardhana previously approved these changes Sep 1, 2020
@balamurugana balamurugana force-pushed the remove-methods-list-remove-incomplete-uploads branch 2 times, most recently from 51de548 to 89e4762 Compare September 2, 2020 05:16
@balamurugana balamurugana changed the title remove methods {list,remove}_incomplete_uploads replace {list,remove}_incomplete_uploads with private methods. Sep 2, 2020
As `minio-py` does not leave stale multipart uploads,
`list_incomplete_uploads()` and `remove_incomplete_uploads()` methods are
removed, but introduced new private methods `_list_mulitpart_uploads()` and
`_list_parts()` for low level usage.
@balamurugana balamurugana force-pushed the remove-methods-list-remove-incomplete-uploads branch from 89e4762 to 36f9dd4 Compare September 2, 2020 05:55
@harshavardhana harshavardhana merged commit 460024d into minio:master Sep 2, 2020
@balamurugana balamurugana deleted the remove-methods-list-remove-incomplete-uploads branch September 3, 2020 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants