Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {set,get}_bucket_versioning() APIs #975

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Sep 10, 2020

Fixes #974

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes. So, this is a major refactoring job addressing 2 issues; #974 and ? (refactoring task of putting http execution at one place).
Probably it would be a good idea to change the title;
Add {set,get}_bucket_versioning() APIs

minio/api.py Outdated Show resolved Hide resolved
@balamurugana
Copy link
Member Author

Lots of changes. So, this is a major refactoring job addressing 2 issues; #974 and ? (refactoring task of putting http execution at one place).
Probably it would be a good idea to change the title;
Add {set,get}_bucket_versioning() APIs

As mentioned in the description (first comment), this PR Depends on #968

ebozduman
ebozduman previously approved these changes Sep 19, 2020
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 0ca673b into minio:master Sep 25, 2020
@balamurugana balamurugana deleted the fix-issue-974 branch October 15, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GetBucketVersioning API
4 participants