Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add {set,get,delete}_{bucket,object}_tags APIs #982

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Add {set,get,delete}_{bucket,object}_tags APIs #982

merged 1 commit into from
Oct 19, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Sep 30, 2020 •
edited
Loading

No description provided.

@balamurugana balamurugana marked this pull request as draft September 30, 2020 14:20
@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_tags-apis branch 2 times, most recently from 442b52c to 1c71aea Compare October 2, 2020 05:41
@balamurugana balamurugana changed the title add {set,get,delete}_bucket_tagging APIs Add {set,get,delete}_{bucket,object}_tags APIs Oct 2, 2020
@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_tags-apis branch from 1c71aea to cee711f Compare October 2, 2020 14:02
@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_tags-apis branch from cee711f to 094b48e Compare October 13, 2020 14:22
@balamurugana balamurugana marked this pull request as ready for review October 13, 2020 14:26
@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_tags-apis branch 2 times, most recently from 4c64e95 to 8134c04 Compare October 15, 2020 20:46
Praveenrajmani
Praveenrajmani previously approved these changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit. LGTM otherwise

minio/api.py Outdated Show resolved Hide resolved
@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_tags-apis branch from 8134c04 to 42e12b7 Compare October 16, 2020 11:03
Praveenrajmani
Praveenrajmani previously approved these changes Oct 16, 2020
View reviewed changes
@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_tags-apis branch from 42e12b7 to b25240f Compare October 19, 2020 07:24
@balamurugana balamurugana force-pushed the add-set-get-delete_bucket_tags-apis branch from b25240f to 6443123 Compare October 19, 2020 09:55
@balamurugana balamurugana merged commit 0ca21af into minio:master Oct 19, 2020
@balamurugana balamurugana deleted the add-set-get-delete_bucket_tags-apis branch October 19, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praveenrajmani Praveenrajmani Praveenrajmani approved these changes

@nitisht nitisht nitisht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @nitisht @Praveenrajmani