Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor VersioningConfig with embedded XML handling #988

Merged
merged 1 commit into from
Oct 15, 2020
Merged

refactor VersioningConfig with embedded XML handling #988

merged 1 commit into from
Oct 15, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Oct 3, 2020 •
edited
Loading

No description provided.

@balamurugana balamurugana force-pushed the refactor-VersioningConfig-with-embedded-XML-handling branch from a041b0b to 329709a Compare October 13, 2020 15:15
kannappanr
kannappanr previously approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr requested a review from vadmeste October 14, 2020 06:16
@vadmeste
Copy link
Member 

Traceback (most recent call last):
  File "get_bucket_versioning.py", line 31, in <module>
    config = client.get_bucket_versioning("vadmeste-testver")
  File "/home/anis/work/python/minio-py/minio/api.py", line 911, in get_bucket_versioning
    return unmarshal(VersioningConfig, response.data.encode())
AttributeError: 'bytes' object has no attribute 'encode'

@balamurugana getting bucket versioning does not work ^

@balamurugana balamurugana force-pushed the refactor-VersioningConfig-with-embedded-XML-handling branch from 329709a to e0a3156 Compare October 14, 2020 14:50
@balamurugana
Copy link
Member Author

@vadmeste

@balamurugana getting bucket versioning does not work ^

Fixed the typo.

@vadmeste
Copy link
Member

@balamurugana LGTM, but there is a conflict now.

@balamurugana balamurugana force-pushed the refactor-VersioningConfig-with-embedded-XML-handling branch from e0a3156 to cd0ba53 Compare October 15, 2020 09:26
vadmeste
vadmeste approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

kannappanr
kannappanr approved these changes Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit c081460 into minio:master Oct 15, 2020
@balamurugana balamurugana deleted the refactor-VersioningConfig-with-embedded-XML-handling branch October 15, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannappanr kannappanr kannappanr approved these changes

@vadmeste vadmeste vadmeste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @vadmeste @kannappanr