Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor XML handling of select_object_content() API #993

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Oct 5, 2020

No description provided.

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-select_object_content-API branch from a56a073 to 2a2aca3 Compare October 13, 2020 16:19
@BigUstad
Copy link

The object used in the call exists in s3. It is also copied to the locally running minio server.
For the ame object in s3, minio; minio downloads the file correctly but s3 doesn't..
And examples/select_object_content.py

client = Minio('s3.amazonaws.com', access_key='<ACCESS_KEY_VALUE>', secret_key='<SECRET_KEY_VALUE>')

For locally running minio server.
client = Minio('192.168.1.2:9000', access_key='<ACCESS_KEY_VALUE>', secret_key='<SECRET_KEY_VALUE>', secure=False)

Trace (requests only)
GET /pribkt3?location= HTTP/1.1
Host: 192.168.1.2:9000
User-Agent: MinIO (Darwin; x86_64) minio-py/7.0.0
X-Amz-Content-Sha256:
X-Amz-Date: 20201015T212037Z
Authorization: AWS4-HMAC-SHA256 Credential=REDACTED/20201015/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=REDACTED

GET /?location= HTTP/1.1
Host: amazonaws.com
User-Agent: MinIO (Darwin; x86_64) minio-py/7.0.0
X-Amz-Content-Sha256: UNSIGNED-PAYLOAD
X-Amz-Date: 20201015T212037Z
Authorization: AWS4-HMAC-SHA256 Credential=REDACTED/20201015/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=REDACTED

which results in this error:

Traceback (most recent call last): File "examples/select_object_content.py", line 57, in <module> data = client.select_object_content('pribkt3', 'samplecsvdata/archive/TotalPopulationByGender.csv.gz', request) <Trace...> minio.error.S3Error: S3 operation failed; code: AllAccessDisabled, message: All access to this object has been disabled, resource: None, request_id: AE024B3CFA45B583, host_id:<value>

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-select_object_content-API branch from 2a2aca3 to da07861 Compare October 15, 2020 21:45
Copy link

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look exceptions of client with s3 server.

@balamurugana
Copy link
Member Author

Please look exceptions of client with s3 server.

Please use the fix #1004

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit b12373b into minio:master Oct 19, 2020
@balamurugana balamurugana deleted the Refactor-XML-handling-of-select_object_content-API branch October 19, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants