Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor XML handling of remove_objects() API #995

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Refactor XML handling of remove_objects() API #995

merged 2 commits into from
Oct 19, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Oct 6, 2020 •
edited
Loading

No description provided.

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-remove_objects-API branch 2 times, most recently from bcb8d8e to a1444d3 Compare October 14, 2020 05:30
@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-remove_objects-API branch 3 times, most recently from 799c47d to 5777b0d Compare October 16, 2020 00:43
ebozduman
ebozduman requested changes Oct 16, 2020
View reviewed changes
minio/deleteobjects.py Outdated Show resolved Hide resolved
minio/deleteobjects.py Outdated Show resolved Hide resolved
@ebozduman
Copy link
Collaborator

It looks like you also need to address the build check failures.

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-remove_objects-API branch 4 times, most recently from df75e51 to 87ea6e8 Compare October 16, 2020 15:34
ebozduman
ebozduman requested changes Oct 17, 2020
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace ResponseError with S3Error in ../examples/remove_object.py

from minio.error import ResponseError

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-remove_objects-API branch from 87ea6e8 to 611bf96 Compare October 19, 2020 07:17
ebozduman
ebozduman previously approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-remove_objects-API branch from 611bf96 to 1e38877 Compare October 19, 2020 11:01
@balamurugana balamurugana force-pushed the Refactor-XML-handling-of-remove_objects-API branch from 1e38877 to 9088232 Compare October 19, 2020 17:10
kannappanr
kannappanr approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr removed the request for review from krisis October 19, 2020 17:42
ebozduman
ebozduman approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit f31576b into minio:master Oct 19, 2020
@balamurugana balamurugana deleted the Refactor-XML-handling-of-remove_objects-API branch October 19, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannappanr kannappanr kannappanr approved these changes

@ebozduman ebozduman ebozduman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @ebozduman @kannappanr