Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --disable-multipart flag to allow testing without multipart #102

Merged
merged 1 commit into from
Apr 30, 2020
Merged

add --disable-multipart flag to allow testing without multipart #102

merged 1 commit into from
Apr 30, 2020

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Apr 30, 2020 •
edited
Loading

No description provided.

klauspost
klauspost requested changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no case where more than concurrent connections are open to a single host and transport is unique per host.

Disable multipart is time, and tweaking the timeout is fine.

@harshavardhana harshavardhana changed the title allow MaxIdleConns to be nhosts * concurrency add --disable-multipart flag to allow testing without multipart Apr 30, 2020
@harshavardhana
Copy link
Member Author

made the change @klauspost PTAL

klauspost
klauspost approved these changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! And good spotting the SSE! 👍

@harshavardhana harshavardhana merged commit dfa46a6 into minio:master Apr 30, 2020
@harshavardhana harshavardhana deleted the continue branch April 30, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauspost klauspost klauspost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshavardhana @klauspost