Mixed analysis: Disregard errors from totals #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disregard errors from mixed analysis and don't require all threads to have completed for the mixed totals. This could make totals and partial results diverge quite a bit. For mixed operations time filter operations consistently by doing only one time segmentation and use that for individual ops as well. If there are errors don't do time filtering, so we don't hide them. Before: ``` 1354872 operations loaded... Done! Mixed operations. Operation: GET, 64%, Concurrency: 96, Duration: 10m0s. Errors: 44 * Throughput: 49.27 MiB/s, 1128.98 obj/s Operation: PUT, 64%, Concurrency: 96, Duration: 10m0s. Errors: 19 * Throughput: 49.39 MiB/s, 1128.98 obj/s Cluster Total: 94.71 MiB/s, 2169.14 obj/s ``` After: ``` 1354872 operations loaded... Done! Mixed operations. Operation: GET, 50%, Concurrency: 96, Duration: 10m0s. Errors: 44 * Throughput: 49.27 MiB/s, 1128.98 obj/s Operation: PUT, 50%, Concurrency: 96, Duration: 10m0s. Errors: 19 * Throughput: 49.39 MiB/s, 1128.98 obj/s Cluster Total: 98.66 MiB/s, 2257.96 obj/s over 10m0s. ```
klauspost
force-pushed
the
mixed-disregard-errors
branch
from
62067d8 to
acf4a84
Compare
harshavardhana
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disregard errors from mixed analysis and don't require all threads to have completed for the mixed totals.
This could make totals and partial results diverge quite a bit and makes the total operations not match up.
For mixed operations time filter operations consistently by doing only one time segmentation and use that for individual ops as well.
If there are errors don't do time filtering, so we don't hide them.
Before:
After: