Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a format for object-size providing a wieighted random based on configured buckets #342

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

jfsmig
Copy link
Contributor

@jfsmig jfsmig commented Oct 22, 2024

Allows a coma-separated set of colon-separated pairs, describing buckets and their respective weights. This format triggers an option that performs a weighted random number generation when a new object is created.

E.g.: 4096:10740,8192:1685,16384:1623 will trigger objects whose size will be chosen between 0 and 4096 with a weight of 10740, between 4096 and 8192 with a weight of 1685, or between 8192 and 16384 with a weight of 1623.

Allows a coma-separated set of colon-separated pairs, describing buckets
and their respective weights. This format triggers an option that
performs a weighted random number generation when a new object is
created.

E.g.: `4096:10740,8192:1685,16384:1623` will trigger objects whose size
will be chosen between 0 and 4096 with a weight of 10740, between 4096
and 8192 with a weight of 1685, or between 8192 and 16384 with a weight
of 1623.
@jfsmig jfsmig force-pushed the JFS/master/size-histograms branch from f02182f to 174b91c Compare October 22, 2024 13:21
Copy link
Collaborator

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and cleanly implemented 👍🏼

Please add a section to the README on it.

Copy link
Collaborator

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 lgtm

@harshavardhana harshavardhana merged commit 316d79c into minio:master Oct 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants