Allow for VersionNoPrefix in VersionFormat #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 2137 2138 +1
=========================================
+ Hits 2137 2138 +1 ☔ View full report in Codecov by Sentry. |
cosmastech
changed the title
|
Not sure if there are documentation changes to be made. Happy to implement anything you think the PR is missing! Thanks |
The comment above the new struct value is part of the generated docs so you are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VersionNoPrefix can now be included in the VersionFormat (
## {{.VersionNoPrefix}}) so a change can look like## 2.0.1instead of## v2.0.1.Closes #586
Check the following
Additional context
Any additional info that might help get your pull request merged.