Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid deprecated properties in goreleaser integration config #603

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

reitzig
Copy link
Contributor

@reitzig reitzig commented Feb 1, 2024

changelog.skip has been deprecated in favor of changelog.disable since 2024-01-14

cf. https://goreleaser.com/deprecations/#changelogskip

Check the following

  • Keep 100% code coverage
  • Be properly formatted
  • Documentation changes are included
  • Include a change file if expected

Additional context
Any additional info that might help get your pull request merged.

@miniscruff
Copy link
Owner

Oh cool, can you also change the value in changie's config here https://github.com/miniscruff/changie/blob/main/.goreleaser.yml#L87

@reitzig reitzig marked this pull request as ready for review February 4, 2024 13:55
@reitzig
Copy link
Contributor Author

reitzig commented Feb 4, 2024

ℹ️ This change hasn't been released yet; goreleaser/goreleaser@v1.23.0 is from last December.

Didn't notice that before, my bad. Suggest to hold back on merging until 1.24 drops.

@miniscruff
Copy link
Owner

Will do, I will mark this as draft and on hold until I notice the new release. Thanks for the help.

@miniscruff miniscruff added skip changelog Non-user impacting change hold On hold until further notice labels Feb 4, 2024
@miniscruff miniscruff marked this pull request as draft February 4, 2024 21:58
@miniscruff
Copy link
Owner

For future miniscruff:

We are waiting on goreleaser 1.24 with the new config change, hopefully I get the notification for it.

`changelog.skip` has been deprecated in favor of `changelog.disable` since 2024-01-14

cf. https://goreleaser.com/deprecations/#changelogskip
@reitzig
Copy link
Contributor Author

reitzig commented Feb 8, 2024

They done it! 🥳
➡️ goreleaser/goreleaser@v1.24.0

@reitzig reitzig marked this pull request as ready for review February 8, 2024 09:58
@miniscruff miniscruff removed the hold On hold until further notice label Feb 11, 2024
@miniscruff miniscruff merged commit 3e31b28 into miniscruff:main Feb 11, 2024
2 checks passed
@miniscruff
Copy link
Owner

Merged, will redeploy the website as well for that update.

@miniscruff
Copy link
Owner

Ok website is now also updated, thanks for the patch @reitzig

@reitzig reitzig deleted the patch-1 branch February 12, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Non-user impacting change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants