Fix kubernetes client patch for RBAC #504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoen
reviewed
Jan 28, 2019
| if ('name' not in provider | ||
| or 'config' not in provider | ||
| or provider['name'] != 'oidc'): | ||
| def load_token(self, provider): |
There was a problem hiding this comment.
I see that provider was taken out from the self._user['auth-provider'] before but now it's a parameter of load_token() - I can't see the change to the client code calling this tho, what am I missing?
There was a problem hiding this comment.
load_token is a monkey patch for KubeConfigLoad._load_oid_token in the Python Kubernetes client library. They have a fix for the issue in a PR, but it has been waiting to be merged for months. Hopefully they will merge it soon and we can remove this patch.
In the meantime, they changed the signature of _load_oid_token to take the provider dict, so this change is to keep up.
|
Proper fix in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What