Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGA-3319: Add additional MI Scope Report tests for new notes format #1251

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

LGA-3319: Add additional MI Scope Report tests for new notes format #1251

wants to merge 7 commits into from

Conversation

BenMillar-MOJ
Copy link
Contributor

@BenMillar-MOJ BenMillar-MOJ commented Nov 4, 2024 •
edited
Loading

What does this pull request do?

  • Adds additional unit tests to the MI Scope Report to validate that the report still handles notes using example content from the new frontend.
  • Updates the MI Scope Report to correctly handle outcomes with multiple words. I.e. "In Scope - Skip means test"

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@BenMillar-MOJ BenMillar-MOJ requested a review from a team as a code owner November 4, 2024 20:07
said-moj
said-moj previously approved these changes Nov 5, 2024
View reviewed changes
@said-moj said-moj self-requested a review November 5, 2024 09:20
@BenMillar-MOJ BenMillar-MOJ force-pushed the feature/LGA-3319-Add-additional-scope-report-tests branch from f6322b0 to 992408a Compare November 6, 2024 00:26
@BenMillar-MOJ BenMillar-MOJ force-pushed the feature/LGA-3319-Add-additional-scope-report-tests branch from 992408a to d51a88c Compare November 6, 2024 00:36
TawneeOwl
TawneeOwl approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!!!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TawneeOwl TawneeOwl TawneeOwl approved these changes

@said-moj said-moj Awaiting requested review from said-moj

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenMillar-MOJ @said-moj @TawneeOwl