Add instructions for RDS restore from snapshot #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalronin
suggested changes
Feb 19, 2020
| } | ||
| ``` | ||
|
|
||
| It is important to retain the original settings associated with the DB instance when restoring from the snapshot. Hence, most of the restore should be done through terraform code. |
There was a problem hiding this comment.
I'd probably replace;
Hence, most of the restore should be done through terraform code.
with "So don't make any other changes to this file."
Users can't do a restore any other way than by raising a PR with terraform changes, so the important thing here is that the only add the snapshot_identifier, and don't mess with anything else.
|
|
||
| 5. Merge the PR to master and check for the build pipeline to create the new DB instance with the same Identifier and endpoints. Cloud Platform can also apply your changes manually if this is time critical. | ||
|
|
||
| Once the new DB instance is restored, your application should be able to access the database with the same database credentials and endpoint. |
There was a problem hiding this comment.
Do we need to add something about letting the CP team know they can delete the renamed database (if there is one)?
There was a problem hiding this comment.
Added info on when users needs to inform about deleting the instance.
digitalronin
approved these changes
Feb 20, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #30
This PR is related to recovering live RDS instance from snapshot.
Testing the Disaster recovery in a different namespace is currently not supported without complex steps involved using AWS console.
Revisit the ticket after the terraform provider support is available. Refer: hashicorp/terraform-provider-aws#9885