SDI-126: ✨ Use description for absent reason #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergphillips
commented
Apr 20, 2022
| @@ -35,7 +35,6 @@ export const whereaboutsApiFactory = (client) => { | |||
|
|
|||
| const putAttendance = (context, body, id) => put(context, `/attendance/${id}`, body) | |||
|
|
|||
| const getAbsenceReasons = (context) => get(context, '/absence-reasons') | |||
There was a problem hiding this comment.
no longer used as whereabouts now returns descriptions too
petergphillips
commented
Apr 20, 2022
| } from '../../utils' | ||
|
|
||
| const attendanceReasonStatsUrl = '/manage-prisoner-whereabouts/attendance-reason-statistics' | ||
|
|
||
| const formatReason = ({ name, triggersIEPWarning }) => |
There was a problem hiding this comment.
now just using whereabouts description
petergphillips
commented
Apr 20, 2022
| @@ -309,7 +300,7 @@ export const attendanceStatisticsFactory = (oauthApi, prisonApi, whereaboutsApi) | |||
| }) | |||
|
|
|||
| const offenderData = absences.map((absence) => ({ | |||
| offenderName: `${capitalize(absence.lastName)}, ${capitalize(absence.firstName)}`, | |||
| offenderName: putLastNameFirst(absence.firstName, absence.lastName), | |||
There was a problem hiding this comment.
use better method for formatting the offender name too
petergphillips
commented
Apr 20, 2022
| @@ -300,7 +291,7 @@ export const attendanceStatisticsFactory = (oauthApi, prisonApi, whereaboutsApi) | |||
| ) | |||
| } | |||
|
|
|||
| const { absences } = await whereaboutsApi.getAbsences(res.locals, { | |||
| const { absences, description: displayReason } = await whereaboutsApi.getAbsences(res.locals, { | |||
There was a problem hiding this comment.
get description from whereabouts
petergphillips
force-pushed
the
pgp-SDI-126-use-description-2
branch
from
cb1b65f
to
e32d394
Compare
petergphillips
force-pushed
the
pgp-SDI-126-use-description-2
branch
from
e32d394
to
1314d8a
Compare
lbennett-moj
approved these changes
Apr 20, 2022
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.