Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NN-4065 NN-4065 restricted patient access #2146

Merged
merged 8 commits into from
May 13, 2022
Merged

NN-4065 NN-4065 restricted patient access #2146

merged 8 commits into from
May 13, 2022

Conversation

timoj58
Copy link
Contributor

@timoj58 timoj58 commented May 12, 2022 •
edited
Loading

changes to allow POM access to restricted patients in their case load.

Note: the cpress int tests fails specifically on a select (gov,uk) due to the following code not adding user in middleware

digital-prison-services/backend/middleware/currentUser.ts

Line 30 in 14f70f3

if (!req.xhr) {

Therefore the prisonerProfileContext is checking if the user is defined, if not, it will simply return the current context

@timoj58 timoj58 requested a review from Mjwillis May 13, 2022 10:41
Mjwillis
Mjwillis approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@Mjwillis Mjwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, my only concern is are we now getting a token on every request or caching?

@timoj58 timoj58 merged commit 791102a into main May 13, 2022
@timoj58 timoj58 deleted the NN-4065 branch May 13, 2022 13:34
andrewrlee added a commit that referenced this pull request May 23, 2022
@andrewrlee
Revert "NN-4065 NN-4065 restricted patient access (#2146)"
b87c5a3 
This reverts commit 791102a.
andrewrlee added a commit that referenced this pull request May 23, 2022
@andrewrlee
DCS-1614 Hefty reverts (#2163)
707adb1 
* Revert "Revert "NN-4019: Add catch wrapper for probation docs (#2147)" (#2162)"

This reverts commit 55e7399.

* Revert "DCS-1614 HMP Durham can access wpip (#2161)"

This reverts commit aadaefa.

* Revert "ESWE-287_feature_flag_neurodivergence_indicator_repair (#2158)"

This reverts commit 5fb3a57.

* Revert "NN-4114: Caching of auth client credentials (again) (#2155)"

This reverts commit 5afb927.

* Revert "VB-816: Update PVB_URL for link on tab (#2159)"

This reverts commit 901fd66.

* Revert "Revert "NN-4114: Caching of auth client credentials (#2150)" (#2154)"

This reverts commit c934a21.

* Revert "NN-4114: Caching of auth client credentials (#2150)"

This reverts commit 6bd1b87.

* Revert " NN-4065 changes to enable a case note to be added (#2152)"

This reverts commit 8c3fc4f.

* Revert "include result of rp check for profile service edit mode (#2151)"

This reverts commit 8c1faa1.

* Revert "NN-4019: Add catch wrapper for probation docs (#2147)"

This reverts commit 12f16e0.

* Revert "add to env (#2149)"

This reverts commit ef2640c.

* Revert "NN-4065 NN-4065 restricted patient access (#2146)"

This reverts commit 791102a.

* Revert "NN-4070: Conditionally remove previous and next links on pagination (#2145)"

This reverts commit 14f70f3.

* Revert "SDI-88: ⚰️ Remove unused file as app is using houseblockResultsSorter.js instead (#2141)"

This reverts commit bcea0a1.

* Revert "Revert "DCS-1614 HMP Durham can access wpip (#2161)""

This reverts commit c3cfa5c.
andrewrlee added a commit that referenced this pull request May 23, 2022
@andrewrlee
Revert "DCS-1614 Hefty reverts (#2163)"
253b2b8 
This reverts commit 707adb1.

Revert "DCS-1614 Hefty reverts (#2163)"

This reverts commit 707adb1.

DCS-1614 Hefty reverts (#2163)

* Revert "Revert "NN-4019: Add catch wrapper for probation docs (#2147)" (#2162)"

This reverts commit 55e7399.

* Revert "DCS-1614 HMP Durham can access wpip (#2161)"

This reverts commit aadaefa.

* Revert "ESWE-287_feature_flag_neurodivergence_indicator_repair (#2158)"

This reverts commit 5fb3a57.

* Revert "NN-4114: Caching of auth client credentials (again) (#2155)"

This reverts commit 5afb927.

* Revert "VB-816: Update PVB_URL for link on tab (#2159)"

This reverts commit 901fd66.

* Revert "Revert "NN-4114: Caching of auth client credentials (#2150)" (#2154)"

This reverts commit c934a21.

* Revert "NN-4114: Caching of auth client credentials (#2150)"

This reverts commit 6bd1b87.

* Revert " NN-4065 changes to enable a case note to be added (#2152)"

This reverts commit 8c3fc4f.

* Revert "include result of rp check for profile service edit mode (#2151)"

This reverts commit 8c1faa1.

* Revert "NN-4019: Add catch wrapper for probation docs (#2147)"

This reverts commit 12f16e0.

* Revert "add to env (#2149)"

This reverts commit ef2640c.

* Revert "NN-4065 NN-4065 restricted patient access (#2146)"

This reverts commit 791102a.

* Revert "NN-4070: Conditionally remove previous and next links on pagination (#2145)"

This reverts commit 14f70f3.

* Revert "SDI-88: ⚰️ Remove unused file as app is using houseblockResultsSorter.js instead (#2141)"

This reverts commit bcea0a1.

* Revert "Revert "DCS-1614 HMP Durham can access wpip (#2161)""

This reverts commit c3cfa5c.
@andrewrlee andrewrlee mentioned this pull request May 23, 2022
Closed
andrewrlee pushed a commit that referenced this pull request May 23, 2022
@timoj58 @andrewrlee
NN-4065 NN-4065 restricted patient access (#2146)
f30ad39 
* NN-4065 restricted patient access

* remove log

* use allcaseloads, and check active, note int tests are not putting the caseloads in session

* context test

* add path for cypress

* add undefined check due to cypress test and middleware filtering js calls

* use context in case notes
GurnankCheema pushed a commit that referenced this pull request May 23, 2022
@andrewrlee @petergphillips
@natclamp-moj @sp-watson @timoj58 @psoleckimoj @monskapinga
DCS-1614 Hefty cherry-pick (#2165)
4868b28 
* SDI-88: ⚰️ Remove unused file as app is using houseblockResultsSorter.js instead (#2141)

* NN-4070: Conditionally remove previous and next links on pagination (#2145)

* NN-4070: Conditionally remove previous and next links

* NN-4070: Add test for removal of next link

* NN-4070: Change variable names to make calculation simpler

Co-authored-by: sp-watson <77974320+sp-watson@users.noreply.github.com>

* NN-4065 NN-4065 restricted patient access (#2146)

* NN-4065 restricted patient access

* remove log

* use allcaseloads, and check active, note int tests are not putting the caseloads in session

* context test

* add path for cypress

* add undefined check due to cypress test and middleware filtering js calls

* use context in case notes

* add to env (#2149)

* NN-4019: Add catch wrapper for probation docs (#2147)

Co-authored-by: sp-watson <steve.watson@digital,justice.gov.uk>
Co-authored-by: Nat Clamp <84783598+natclamp-moj@users.noreply.github.com>

* include result of rp check for profile service edit mode (#2151)

* NN-4065 changes to enable a case note to be added (#2152)

* changes to enable a case note to be added

* fix test, added POM role to client token too

* NN-4114: Caching of auth client credentials (#2150)

* NN-4114: Implement oauth client cred caching

* NN-4114: Fix int tests

* NN-4114: Fix redis error logging

* NN-4114: More lenient expiry time checks

* NN-4114: Only log on non-prod systems

Co-authored-by: sp-watson <steve.watson@digital,justice.gov.uk>

* Revert "NN-4114: Caching of auth client credentials (#2150)" (#2154)

This reverts commit 6bd1b87.

* VB-816: Update PVB_URL for link on tab (#2159)

* NN-4114: Caching of auth client credentials (again) (#2155)

* Revert "Revert "NN-4114: Caching of auth client credentials (#2150)" (#2154)"

This reverts commit c934a21.

* NN-4114: Use system client for client creds cache

Co-authored-by: sp-watson <steve.watson@digital,justice.gov.uk>

* ESWE-287_feature_flag_neurodivergence_indicator_repair (#2158)

* ESWE-287: feature flag neurodiversity indicator refactor to restrict access to accelerated prisons

* ESWE-287: feature flag neurodiversity indicator refactor to restrict access to accelerated prisons

* ESWE-287: feature flag neurodiversity indicator refactor to restrict access to accelerated prisons

* ESWE-287: feature flag neurodiversity indicator refactor to restrict access to accelerated prisons

* ESWE-287: feature flag neurodiversity indicator refactor to restrict access to accelerated prisons

* ESWE-287: feature flag neurodiversity indicator refactor to restrict access to accelerated prisons

* Revert "NN-4019: Add catch wrapper for probation docs (#2147)" (#2162)

This reverts commit 12f16e0.

Co-authored-by: petergphillips <peter@greenthistle.co.uk>
Co-authored-by: Nat Clamp <84783598+natclamp-moj@users.noreply.github.com>
Co-authored-by: sp-watson <77974320+sp-watson@users.noreply.github.com>
Co-authored-by: Tim Wright <wright.tim.j@gmail.com>
Co-authored-by: sp-watson <steve.watson@digital,justice.gov.uk>
Co-authored-by: Paul Solecki <51918433+psoleckimoj@users.noreply.github.com>
Co-authored-by: mons <mons.kapinga@digital.justice.gov.uk>
andrewrlee pushed a commit that referenced this pull request May 23, 2022
@timoj58 @andrewrlee
NN-4065 NN-4065 restricted patient access (#2146)
a8b191b 
* NN-4065 restricted patient access

* remove log

* use allcaseloads, and check active, note int tests are not putting the caseloads in session

* context test

* add path for cypress

* add undefined check due to cypress test and middleware filtering js calls

* use context in case notes
andrewrlee pushed a commit that referenced this pull request May 24, 2022
@timoj58 @andrewrlee
NN-4065 NN-4065 restricted patient access (#2146)
b443fcd 
* NN-4065 restricted patient access

* remove log

* use allcaseloads, and check active, note int tests are not putting the caseloads in session

* context test

* add path for cypress

* add undefined check due to cypress test and middleware filtering js calls

* use context in case notes
@GurnankCheema GurnankCheema mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mjwillis Mjwillis Mjwillis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timoj58 @Mjwillis