NN-4019: Re-instate catch wrapper for probation docs

backend/index.ts

@@ -37,14 +37,13 @@ import homepageController from './controllers/homepage/homepage'
 import deprecatedUrlPage from './controllers/deprecatedUrlPage'
 import requestLimiter from './middleware/requestLimiter'
 
-process.on('uncaughtExceptionMonitor', (err, origin) => {
-  logError('UncuaghtExcMon', err, origin)
-})
+// We do not want the server to exit, partly because any log information will be lost.
+// Instead, log the error so we can trace, diagnose and fix the problem.
 process.on('uncaughtException', (err, origin) => {
-  logError('UncuaghtExc', err, origin)
+  logError('uncaughtException', err, origin)
 })
 process.on('unhandledRejection', (reason, promise) => {
-  console.log('Unhandled Rejection at: ', promise, 'reason:', reason)
+  logError(`unhandledRejection`, {}, `Unhandled Rejection at: ${promise} reason: ${reason}`)
 })
 
 const app = express()

backend/routes.ts

@@ -49,6 +49,7 @@ import appointmentConfirmDeletion from './controllers/appointmentConfirmDeletion
 import appointmentDeleteRecurringBookings from './controllers/appointmentDeleteRecurringBookings'
 import appointmentDeleted from './controllers/appointmentDeleted'
 import { cacheFactory } from './utils/singleValueInMemoryCache'
+import asyncMiddleware from './middleware/asyncHandler'
 
 import whereaboutsRouter from './routes/whereabouts/whereaboutsRouter'
 
@@ -137,7 +138,9 @@ const setup = ({
 
   router.get(
     '/offenders/:offenderNo/probation-documents',
-    probationDocumentsFactory(oauthApi, prisonApi, communityApi, systemOauthClient).displayProbationDocumentsPage
+    asyncMiddleware(
+      probationDocumentsFactory(oauthApi, prisonApi, communityApi, systemOauthClient).displayProbationDocumentsPage
+    )
   )
   router.get(
     '/offenders/:offenderNo/probation-documents/:documentId/download',