Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1751: form_submission event not firing in GA4 #356

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

@MazOneTwoOne MazOneTwoOne commented Sep 25, 2024

What does this pull request do?

  • amend id for one of the questions
  • remove novalidate in form
  • adjust the JS and run only when cookies are allowed

Any other changes that would benefit highlighting?

  • n/a

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

- amend `id` for one of the questions
- remove `novalidate` in form
- adjust the JS and run only when cookies are allowed
@MazOneTwoOne MazOneTwoOne force-pushed the EL-1751-ga4-event-not-firing branch from 94bf3a0 to e29f35d Compare September 25, 2024 10:39
@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review September 25, 2024 10:39
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner September 25, 2024 10:39
- remove other redundant inline JS
Copy link

sonarcloud bot commented Sep 25, 2024

Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MazOneTwoOne MazOneTwoOne merged commit 434aaae into main Sep 27, 2024
8 checks passed
@MazOneTwoOne MazOneTwoOne deleted the EL-1751-ga4-event-not-firing branch September 27, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants