EL-1692: postcode.io validates postcode and country
#357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create a new function called `validate_postcode_and_return_country` which uses `postcode.io` to validate full & partial postcodes and to look up country. - update `clean` method to use `validate_postcode_and_return_country` - add error logging to handle what happens when there is no validate country or when postcode.io is down - add comment about flake8
MazOneTwoOne
force-pushed
the
El-1692-postcode-lookup-validation-using-postcode-io
branch
from
73ab5bf to
62c60a1
Compare
HettieS
reviewed
Oct 1, 2024
- add some retries as per LAALAA repo
psweeting1
reviewed
Oct 2, 2024
psweeting1
reviewed
Oct 2, 2024
- add new test for scottish border postcodes & add extra comments for test cases
|
MazOneTwoOne
deleted the
El-1692-postcode-lookup-validation-using-postcode-io
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
validate_postcode_and_return_countrywhich usespostcode.ioto validate full & partial postcodes and to look up country.cleanmethod to usevalidate_postcode_and_return_countrypostcode.iois down.Any other changes that would benefit highlighting?
nhs_hakey.Checklist