Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1764: Add ability to print FALA results page #367

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

@MazOneTwoOne MazOneTwoOne commented Oct 31, 2024

What does this pull request do?

  • update gulpfile
  • add in css
  • place button on results page
  • rename CSS
  • add in JS
  • don't print footer, banner, beta banner, google translate
  • add css so that content after links don't print
  • wrap pagination with govuk-!-display-none-print class

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review October 31, 2024 16:50
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner October 31, 2024 16:50
- update gulpfile
- add in css
- place button on results page
- rename CSS
- add in JS
- don't print footer, banner, beta banner, google translate
- add css so that content after <a> links don't print
- wrap pagination with `govuk-!-display-none-print` class
@MazOneTwoOne MazOneTwoOne force-pushed the EL-1764-fala-print-results-page branch from 2e538db to 67bbd27 Compare October 31, 2024 16:52
willc-work
willc-work previously approved these changes Oct 31, 2024
Copy link
Contributor

@willc-work willc-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the css and the html but would appreciate @psweeting1 reviewing the JS. Approving t because I have no doubt it works as intended

@MazOneTwoOne MazOneTwoOne added UAT and removed UAT labels Nov 1, 2024
Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Nov 6, 2024

@MazOneTwoOne MazOneTwoOne merged commit b65443d into main Nov 7, 2024
8 checks passed
@MazOneTwoOne MazOneTwoOne deleted the EL-1764-fala-print-results-page branch November 7, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants