Skip to content

Commit

Permalink
Tweak eslint-plugin-import groups
Browse files Browse the repository at this point in the history
It looks like there's a bug[0] in the package which is ignoring our
attempts to group `builtin` and `external` imports introduced with the
update to `2.28.0`.

This groups internal, parent and sibling imports together and seems to
fix the issue for now.

[0]: https://github.com/import-js/eslint-plugin-import/blob/1fa29717518732e3143aaf8155713133c383bf3c/src/rules/order.js#L431

Co-authored-by: Ynda Jas <ynda@dxw.com>
  • Loading branch information
Gweaton and yndajas committed Aug 9, 2023
1 parent 3a13da0 commit ab5a73e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,10 @@
"error",
{
"alphabetize": { "order": "asc", "orderImportKind": "asc" },
"groups": [["builtin", "external"]],
"groups": [
["builtin", "external"],
["internal", "parent", "sibling"]
],
"newlines-between": "always"
}
],
Expand Down

0 comments on commit ab5a73e

Please sign in to comment.