SAA-1536 remove unused deprecated endpoint GET /activities/{ID}, this is no longer used. #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-crowson-moj
force-pushed
the
task/SAA-1536-remove-unused-deprecated-endpoint
branch
from
d668580
to
eb05c2a
Compare
… is no longer used.
matt-crowson-moj
force-pushed
the
task/SAA-1536-remove-unused-deprecated-endpoint
branch
from
eb05c2a
to
fd33cf3
Compare
matt-crowson-moj
commented
Feb 8, 2024
|
|
||
| fun getActivityById(activityId: Long): ModelActivity { | ||
| val activity = activityRepository.findById(activityId) | ||
| .orElseThrow { EntityNotFoundException("Activity $activityId not found") } | ||
| checkCaseloadAccess(activity.prisonCode) |
There was a problem hiding this comment.
Also now doing case load check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
============================================
+ Coverage 86.96% 87.00% +0.03%
- Complexity 3477 3478 +1
============================================
Files 363 363
Lines 12072 12070 -2
Branches 1008 1009 +1
============================================
+ Hits 10499 10501 +2
+ Misses 1106 1102 -4
Partials 467 467 ☔ View full report in Codecov by Sentry. |
smcveigh941
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unused deprecated endpoint
GET /activities/{ID}.All calls that require to get the activity by its ID should go through the filtered endpoint
GET /activities/{ID}/filtered.I have checked Application Insights and cannot see this endpoint used anymore.
Goes with this PR here.