-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAA-1536 remove unused deprecated endpoint GET /activities/{ID}, this is no longer used. #776
SAA-1536 remove unused deprecated endpoint GET /activities/{ID}, this is no longer used. #776
Conversation
d668580
to
eb05c2a
Compare
… is no longer used.
eb05c2a
to
fd33cf3
Compare
|
||
fun getActivityById(activityId: Long): ModelActivity { | ||
val activity = activityRepository.findById(activityId) | ||
.orElseThrow { EntityNotFoundException("Activity $activityId not found") } | ||
checkCaseloadAccess(activity.prisonCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also now doing case load check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
============================================
+ Coverage 86.96% 87.00% +0.03%
- Complexity 3477 3478 +1
============================================
Files 363 363
Lines 12072 12070 -2
Branches 1008 1009 +1
============================================
+ Hits 10499 10501 +2
+ Misses 1106 1102 -4
Partials 467 467 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems an odd name/url for the "filtered" endpoint now that the original is gone, but LGTM
This removes the unused deprecated endpoint
GET /activities/{ID}
.All calls that require to get the activity by its ID should go through the filtered endpoint
GET /activities/{ID}/filtered
.I have checked Application Insights and cannot see this endpoint used anymore.
Goes with this PR here.